Clean-up main model: Add logger interface #1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…feature/logger-interface Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…feature/logger-interface Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
1 task
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
power_grid_model_c/power_grid_model/include/power_grid_model/common/calculation_info.hpp
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
nitbharambe
reviewed
Aug 26, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/common/logging.hpp
Outdated
Show resolved
Hide resolved
nitbharambe
reviewed
Aug 26, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/common/logging_impl.hpp
Outdated
Show resolved
Hide resolved
nitbharambe
reviewed
Aug 26, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/common/logging_impl.hpp
Outdated
Show resolved
Hide resolved
nitbharambe
reviewed
Aug 26, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/common/logging_impl.hpp
Outdated
Show resolved
Hide resolved
nitbharambe
reviewed
Aug 26, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/calculation_info.hpp
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
added
improvement
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
nitbharambe
approved these changes
Sep 1, 2025
| @@ -16,7 +14,9 @@ | |||
| #include "../common/common.hpp" | |||
| #include "../common/matrix_utils.hpp" | |||
| #include "../common/three_phase_tensor.hpp" | |||
| #include "line_utils.hpp" | |||
|
|
|||
| #include <iostream> | |||
There was a problem hiding this comment.
@mgovers can you explain why do we need iostream here?
There was a problem hiding this comment.
i missed this. this was auto-formatted (the #include statement was already there). will remove in a separate PR
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cfr. offline discussion, this experiment was cleaned up and taken to be the first step towards the calculation info cleanup